Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch: version before would have negative patch number: found an example. #35787

Closed
ghost opened this issue Nov 22, 2019 · 1 comment
Closed

cmd/go/internal/modfetch: version before would have negative patch number: found an example. #35787

ghost opened this issue Nov 22, 2019 · 1 comment
Labels
FrozenDueToAge

Comments

@ghost
Copy link

ghost commented Nov 22, 2019

In go.mod in github.com/moby/buildkit, I found this line:

github.com/containerd/containerd v1.4.0-0.20191014053712-acdcf13d5eaf

This is an invalid psedo version: It is in the form of "vX.Y.(Z+1)-0.yyyymmddhhmmss-abcdefabcdef" but (Z+1)=0. It is rejected by go tools.

I came through a comment in cmd/go/internal/modfetch/pseudo.go, saying interested in examples of invalid pseudo versions "vX.0.0-0". Though this is not exactly the case, I think it may still be of interests of determining futher development.
bcmills referenced this issue in moby/buildkit Nov 22, 2019
@AkihiroSuda
vendor containerd
c6641fb 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@bcmills
Copy link
Contributor

bcmills commented Nov 22, 2019

Thanks for the report! I've inquired about the origin of this version string on the GitHub page for the commit that introduced it (moby/buildkit@c6641fb).

I've seen other invalid versions within docker and moby projects originating from hand-edited go.mod files, so I suspect that the same happened here.

@bcmills bcmills closed this as completed Nov 22, 2019
@golang golang locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcmills @gopherbot