Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add a builder that runs long tests with a gccgo toolchain #35786

Open
jayconrod opened this issue Nov 22, 2019 · 6 comments
Open

x/build: add a builder that runs long tests with a gccgo toolchain #35786

jayconrod opened this issue Nov 22, 2019 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder
Projects
Go Release Team
Milestone
Unreleased

Comments

@jayconrod
Copy link
Contributor

From the list at build.golang.org, there don't seem to be any builders running a gccgo toolchain. It would be useful to have one to make sure we don't regress on gccgo support.

For quick reference: gccgo setup instructions
@jayconrod jayconrod added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 22, 2019
@jayconrod jayconrod added this to the Unreleased milestone Nov 22, 2019
@bcmills bcmills mentioned this issue Nov 18, 2020
Closed
@bcmills
Copy link
Contributor

bcmills commented Nov 18, 2020

This missing build configuration masked a failure in a new test (#42688).

(FYI @golang/release for prioritization.)

@bcmills bcmills mentioned this issue Jan 28, 2021
Closed
@bcmills
Copy link
Contributor

bcmills commented Jan 28, 2021

Another masked failure, apparently since Dec. 9: #43974.

@gopherbot
Copy link

Change https://golang.org/cl/287613 mentions this issue: cmd/go: revert TestScript/build_trimpath to use ioutil.ReadFile

gopherbot pushed a commit that referenced this issue Jan 28, 2021
cmd/go: revert TestScript/build_trimpath to use ioutil.ReadFile
41bb49b 
This call was changed to os.ReadFile in CL 266365, but the test also
builds that source file using gccgo if present, and released versions
of gccgo do not yet support ioutil.ReadFile.

Manually tested with gccgo gccgo 10.2.1 (see #35786).

Fixes #43974.
Updates #42026.

Change-Id: Ic4ca0848d3ca324e2ab10fd14ad867f21e0898e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/287613
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@bcmills
Copy link
Contributor

bcmills commented Jul 12, 2022

This masked another failure in CL 416134 — longtest SlowBots were run for that CL, but the only builders that detected the broken test were for secondary ports (aix, illumos, and solaris).

@gopherbot
Copy link

Change https://go.dev/cl/417094 mentions this issue: cmd/go: avoid indexing GOROOT packages when the compiler is 'gccgo'

@heschi
Copy link
Contributor

heschi commented Jul 12, 2022

@bcmills we're probably not going to get to this any time soon. But we're happy to work with you or anyone who feels that it's important to get it set up.

@heschi heschi added this to Planned in Go Release Team Jul 12, 2022
gopherbot pushed a commit that referenced this issue Jul 12, 2022
cmd/go: avoid indexing GOROOT packages when the compiler is 'gccgo'
5f5cae7 
The gccgo compiler does not load standard-library packages from
GOROOT/src, so we cannot load those packages from the GOROOT/src
index when using that compiler.

This fixes TestScript/gccgo_link_c (and perhaps other gccgo tests)
when a 'gccgo' executable is present. Unfortunately, only a few
builders caught the broken test because 'gccgo' is not installed
on most Go project builders (see #35786).

For #53577.
Fixes #53815.

Change-Id: I11a5cf6dbf4ac9893c4d02bd6ab7ef60f67b1e87
Reviewed-on: https://go-review.googlesource.com/c/go/+/417094
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
jproberts pushed a commit to jproberts/go that referenced this issue Aug 10, 2022
@jproberts
cmd/go: avoid indexing GOROOT packages when the compiler is 'gccgo'
62da8d2 
The gccgo compiler does not load standard-library packages from
GOROOT/src, so we cannot load those packages from the GOROOT/src
index when using that compiler.

This fixes TestScript/gccgo_link_c (and perhaps other gccgo tests)
when a 'gccgo' executable is present. Unfortunately, only a few
builders caught the broken test because 'gccgo' is not installed
on most Go project builders (see golang#35786).

For golang#53577.
Fixes golang#53815.

Change-Id: I11a5cf6dbf4ac9893c4d02bd6ab7ef60f67b1e87
Reviewed-on: https://go-review.googlesource.com/c/go/+/417094
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. new-builder
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jayconrod @bcmills @gopherbot @heschi