Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: gomote create doesn't work with older gomote clients #35778

Closed
andybons opened this issue Nov 22, 2019 · 7 comments
Closed

x/build/cmd/coordinator: gomote create doesn't work with older gomote clients #35778

andybons opened this issue Nov 22, 2019 · 7 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unplanned

Comments

@andybons
Copy link
Member 

$ gomote create darwin-amd64-10_10
Error running create: failed to create buildlet: buildlet: failed to create remote buildlet; unexpected missing name in response
$ gomote list
user-andybons-darwin-amd64-10_10-0	darwin-amd64-10_10	host-darwin-10_10	expires in 26m11.407191056s

@dmitshur @cagedmantis @bradfitz @toothrot
@andybons andybons added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 22, 2019
@andybons andybons added this to the Unplanned milestone Nov 22, 2019
@bradfitz
Copy link
Contributor

I made a recent gomote change (https://go-review.googlesource.com/c/build/+/207841) that changed the protocol a bit but it should've been backwards compatible with old clients. Maybe not?

Try updating your gomote if you didn't?

@andybons
Copy link
Member Author

Ah that did it. Thanks, Brad!

@bradfitz
Copy link
Contributor

I'll repurpose this bug to be about fixing the gomote server to work with older clients.

Or just removing the server compat code I added which apparently never worked.

@bradfitz bradfitz reopened this Nov 22, 2019
@bradfitz bradfitz self-assigned this Nov 22, 2019
@bradfitz bradfitz changed the title x/build/cmd/gomote: get error creating macOS buildlet but farmer shows it was created x/build/cmd/coordinator: gomote create doesn't work with older gomote clients Nov 22, 2019
@andybons
Copy link
Member Author

andybons commented Nov 22, 2019 •
edited

Was there a test?

@gopherbot
Copy link

Change https://golang.org/cl/208437 mentions this issue: cmd/coordinator: fix gomote create compatibility for older gomote clients

@bradfitz
Copy link
Contributor

Was there a test?

The gomote stuff isn't wonderfully tested. It's a huge Rube Goldberg machine with huge dependencies. I haven't broken it up to be testable yet. It's just never been a priority given the limited user base. Low SLO service. :)

@andybons
Copy link
Member Author

While not to derail this specific issue, testing and documentation are becoming more of a priority now that there are three additional people focused primarily on this codebase and changing things is very scary at the moment. Even if it comes at the cost of lower velocity in other areas.

@golang golang locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @andybons @gopherbot