Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: File.Seek() not resetting directory reads on MacOS Catalina #35767

Closed
caseybarker opened this issue Nov 22, 2019 · 5 comments
Closed

os: File.Seek() not resetting directory reads on MacOS Catalina #35767

caseybarker opened this issue Nov 22, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Go1.14

Comments

@caseybarker
Copy link

caseybarker commented Nov 22, 2019 •
edited

What version of Go are you using (go version)?

$ go version
go version go1.13.4 darwin/amd64

Does this issue reproduce with the latest release?

This is the latest.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/cbarkerj/Library/Caches/go-build"
GOENV="/Users/cbarkerj/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/cbarkerj/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/9_/kzjd637s5n153w9g3zqc1hmh0000gn/T/go-build108700530=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

This piece of code opens a directory file and calls f.Readdirnames(0). Then it calls f.Seek(0, 0) to reset to the head of the file, and calls f.Readdirnames(0) again.

https://play.golang.org/p/IEb3BH2Jlxg

What did you expect to see?

On Linux, the playground, and earlier versions of MacOS, the second call to f.Readdirnames(0) returns the same directory list as the first call:

$ go build .
$ ./test
2019/11/21 16:56:37 try 1:[test main.go]
2019/11/21 16:56:37 seeked to offset: 0
2019/11/21 16:56:37 try 2:[test main.go]

What did you see instead?

On MacOS 10.15.1 Catalina, the second call returns an empty list:

% go build .
% ./test    
2019/11/21 16:55:22 try 1:[test main.go]
2019/11/21 16:55:22 seeked to offset: 0
2019/11/21 16:55:22 try 2:[]
@networkimprov
Copy link

cc @odeke-em @eliasnaur @ianlancetaylor
@gopherbot add OS-Darwin

@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 22, 2019
@ianlancetaylor ianlancetaylor added this to the Go1.14 milestone Nov 22, 2019
@ianlancetaylor
Copy link
Contributor

I guess this is not a 1.14 release blocker since it is broken in 1.13, but it would be nice to fix.

CC @randall77

@odeke-em odeke-em changed the title file.Seek() not resetting directory reads on MacOS Catalina os: File.Seek() not resetting directory reads on MacOS Catalina Nov 22, 2019
@caseybarker
Copy link
Author

Out of curiosity, I tested File.Seek() for regular file reads. That works as expected.

@randall77
Copy link
Contributor

I think the problem here is that the first Readdirnames calls opendir and caches the result. The behavior of that cached opendir result isn't specified on a seek of the underlying fd:

Upon successful return from fdopendir(), the file descriptor is under the control of the system, and if any attempt is made to close the file descriptor, or to modify the state of the associated description other than by means of closedir(), readdir(), readdir_r(), or rewinddir(), the behavior is undefined.

Seek should really invalidate any outstanding opendir result.
I'll hack up a patch.

@eliasnaur eliasnaur mentioned this issue Dec 4, 2019
Open
@gopherbot
Copy link

Change https://golang.org/cl/209961 mentions this issue: os: reset dirinfo when seeking on Darwin

@odeke-em odeke-em mentioned this issue Feb 11, 2020
Closed
@golang golang locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
5 participants
@networkimprov @ianlancetaylor @randall77 @caseybarker @gopherbot