Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/shiny/driver/mtldriver: build failure on darwin-amd64-10_15 builder #35766

Closed
dmitshur opened this issue Nov 22, 2019 · 1 comment
Closed

x/exp/shiny/driver/mtldriver: build failure on darwin-amd64-10_15 builder #35766

dmitshur opened this issue Nov 22, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Backlog

Comments

@dmitshur
Copy link
Contributor

The new Catalina builder is failing because a dependency is emitting a Cgo warning (which is promoted to an error on builders):

# github.com/go-gl/glfw/v3.2/glfw
In file included from /var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/gopath/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/c_glfw_darwin.go:8:
/var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-10_15/gopath/pkg/mod/github.com/go-gl/glfw@v0.0.0-20190409004039-e6da0acd62b1/v3.2/glfw/glfw/src/cocoa_window.m:989:9: warning: multiple methods named 'center' found [-Wobjc-multiple-method-names]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSCollectionViewCompositionalLayout.h:601:19: note: using
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSWindow.h:312:1: note: also found
go build github.com/go-gl/glfw/v3.2/glfw: C compiler warning promoted to error on Go builders

(Source: https://build.golang.org/log/238e8eb181231f6c5ead1a2159a5544c2b8aef46.)

The fix will be to update to github.com/go-gl/glfw/v3.3/glfw once it becomes available. The newer GLFW version should have this problem resolved.
@dmitshur dmitshur added OS-Darwin NeedsFix The path to resolution is known, but the work has not been done. labels Nov 22, 2019
@dmitshur dmitshur added this to the Backlog milestone Nov 22, 2019
@dmitshur dmitshur self-assigned this Nov 26, 2019
@gopherbot
Copy link

Change https://golang.org/cl/208877 mentions this issue: shiny/driver/mtldriver: update to GLFW v3.3

@golang golang locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot