cmd/go: go run leaves directories behind in /tmp #3572
Labels
Milestone
Comments
Too bad there's no portable remove-on-close capability. Labels changed: added priority-soon, removed priority-triage. Owner changed to @rsc. Status changed to Accepted. |
Presumably go run should ignore the signal, wait for the child to exit, and clean up. See also issue #3581. |
@rsc, the intention of ctrl-c is "I want this program to be stopped now". So, I think, ignoring the signal is not acceptable. Perhaps we could intercept ctrl+c and send it to the child process instead, and then wait for it to finish. Not sure about unix, but windows version, probably, should start child process in a new process group, like we already do in one of our tests in os/signal. Alex |
https://golang.org/cl/6903061/ Status changed to Started. |
|
Owner changed to @alexbrainman. |
Russ, do you agree with Dave's suggestion https://golang.org/cl/6903061/#msg6 ? Or should I leave out changes to "go test" altogether? Alex |
|
This issue was closed by revision 04f0d14. Status changed to Fixed. |
wathiede
added
fixed
Suggested
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What steps will reproduce the problem? If possible, include a link to a program on play.golang.org. 0. $ ls -d /tmp/go-build*|wc -l ls: /tmp/go-build*: No such file or directory 0 1. go run www.go # See bottom of bug for source 2. Hit ctrl-c 3. $ ls -d /tmp/go-build*|wc -l 1 What is the expected output? I would expect files to be cleaned up on exit. What do you see instead? A go-build directory per 'go run' invocation Which compiler are you using (5g, 6g, 8g, gccgo)? I'm using a 64-bit build, so I assume 8g Which operating system are you using? FreeBSD 8.2 Which version are you using? (run 'go version') go version go1 built from source: $ hg sum parent: 12872:920e9d1ffd1f go1 release go1 branch: release-branch.go1 commit: (clean) update: (current) Please provide any additional information below. // www.go package main import ( "fmt" "log" "net/http" ) func main() { http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { fmt.Fprintf(w, "Hello") }) log.Fatal(http.ListenAndServe(":8080", nil)) }The text was updated successfully, but these errors were encountered: