Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: make contended gomote create request cancel post-submit build #35714

Closed
bradfitz opened this issue Nov 20, 2019 · 1 comment
Closed

x/build/cmd/coordinator: make contended gomote create request cancel post-submit build #35714

bradfitz opened this issue Nov 20, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

If somebody wants to gomote create a reverse buildlet that's busy doing a post-submit build, the coordinator could pick an active build (say, the most recently started) and call (*buildStatus).cancelBuild() on it, to make it clean up and return itself to the coordinator, so the scheduler will get it soon and give it to gomote.

/cc @mknyszek @aclements @dmitshur @cagedmantis
@gopherbot gopherbot added this to the Unreleased milestone Nov 20, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 20, 2019
@bradfitz bradfitz added FeatureRequest and removed Builders x/build issues (builders, bots, dashboards) labels Nov 20, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 20, 2019
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 22, 2019
@gopherbot
Copy link

Change https://golang.org/cl/209757 mentions this issue: cmd/coordinator: make contended gomote create request cancel post-submit build

@golang golang locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @toothrot @gopherbot