New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/coordinator: implement trybot set cancellation #35701
Comments
Change https://golang.org/cl/207842 mentions this issue: |
Pardon the comment on a closed issue, but it wasn't clear in the CL, so I wanted to clarify: When does the cancellation happen ? Can it be triggered from the UI ? Or it is always automatic ? If so, does it happen when someone uploads a new patchset while an existing run is happening ? |
I understand what's implemented now is that when a "Run-TryRun" vote is deleted in Gerrit, the try run is canceled. For example, see https://go-review.googlesource.com/c/sys/+/207858/3#message-dfc5c634bdb023398d74a476d3ba5f100beef00f. Edit: My understanding is based on a quick read of https://github.com/golang/build/blob/f7862f789e264f7bf2f6cca4ce8231ec9034249a/cmd/coordinator/coordinator.go#L1013-L1016 and may be wrong. |
Thanks. That looks like one needs the "Delete-tryrun" permission bits. It would be nice to have it automatically cancel a running build when a new patchset is mailed. |
@agnivade, new patchsets automatically delete the Run-TryBot vote, because we don't have https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyMaxScore set to true on that label. So you don't need any new permissions to cancel a trybot run. You just need to upload a new patchset. |
TryBot runs can't be canceled right now. It's mostly implemented, but ends here:
So they don't actually cancel.
/cc @cagedmantis @dmitshur @bcmills
The text was updated successfully, but these errors were encountered: