Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: update go doc on runtime.gcMarkRootPrepare #35683

Closed
Petelin opened this issue Nov 19, 2019 · 2 comments
Closed

runtime: update go doc on runtime.gcMarkRootPrepare #35683

Petelin opened this issue Nov 19, 2019 · 2 comments
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@Petelin
Copy link

Petelin commented Nov 19, 2019 

// gcMarkRootPrepare queues root scanning jobs (stacks, globals, and
// some miscellany) and initializes scanning-related state.
//
// The caller must have call gcCopySpans().
//
// The world must be stopped.
//
//go:nowritebarrier
func gcMarkRootPrepare() {

this gcCopySpans() already not exist.
@ianlancetaylor ianlancetaylor changed the title update go doc on runtime.gcMarkRootPrepare runtime: update go doc on runtime.gcMarkRootPrepare Nov 19, 2019
@ianlancetaylor ianlancetaylor added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Nov 19, 2019
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Nov 19, 2019
@ianlancetaylor
Copy link
Contributor

CC @aclements

@gopherbot
Copy link

Change https://golang.org/cl/209917 mentions this issue: runtime: remove comment about gcCopySpans()

@golang golang locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @Petelin