Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/internal/socket: TestRace failing on linux-amd64-nocgo #35668

Closed
bcmills opened this issue Nov 18, 2019 · 1 comment
Closed

x/net/internal/socket: TestRace failing on linux-amd64-nocgo #35668

bcmills opened this issue Nov 18, 2019 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 18, 2019 •
edited

CL 205461 added TestRace to x/net/internal/socket.

The test intentionally runs a racy program and expects it to fail. However, the race detector is sensitive to the particulars of goroutine scheduling, and with optimizations disabled that schedule apparently does not trigger race detection for this particular program.

(This is a release-blocker due to its impact on #11811.)

https://build.golang.org/log/c46cbf57e4c0f017b1703167baacf24e2c88cf4c:

--- FAIL: TestRace (0.02s)
    --- FAIL: TestRace/test_0 (0.01s)
        socket_test.go:363: race not detected for test 0: err:exit status 2 out:go run: -race requires cgo; enable cgo by setting CGO_ENABLED=1
    --- FAIL: TestRace/test_1 (0.01s)
        socket_test.go:363: race not detected for test 1: err:exit status 2 out:go run: -race requires cgo; enable cgo by setting CGO_ENABLED=1
FAIL
FAIL	golang.org/x/net/internal/socket	0.030s

CC @randall77 @bradfitz @odeke-em
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 18, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 18, 2019
@gopherbot
Copy link

Change https://golang.org/cl/207677 mentions this issue: internal/socket: add cgo build tag to race detection test

@bcmills bcmills mentioned this issue Feb 20, 2020
Closed
@golang golang locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@bcmills @randall77 @gopherbot