Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/chrome/gophertool/background.js: chrome.tabs.getSelected is deprecated since Chrome 33 #35663

Closed
ramenjuniti opened this issue Nov 18, 2019 · 2 comments
Closed

misc/chrome/gophertool/background.js: chrome.tabs.getSelected is deprecated since Chrome 33 #35663

ramenjuniti opened this issue Nov 18, 2019 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@ramenjuniti
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.13 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ramenjuniti/Library/Caches/go-build"
GOENV="/Users/ramenjuniti/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/ramenjuniti/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/9m/v4kppwmn6_d17tqn09hr4hd80000gn/T/go-build144248858=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

chrome Extension APIs documents shows tabs.getSelected like this:

Deprecated since Chrome 33. Please use tabs.query {active: true}.

https://developer.chrome.com/extensions/tabs#method-getSelected

But tabs.getSelected is used in misc/chrome/gophertool/background.js.
tabs.query shoud be used instead of tabs.getSelected.

What did you expect to see?

tabs.query is used in misc/chrome/gophertool/background.js.

What did you see instead?

tabs.getSelected is used in misc/chrome/gophertool/background.js.
@gopherbot
Copy link

Change https://golang.org/cl/207401 mentions this issue: misc/chrome/gophertool: replace a deprecated API

@gopherbot
Copy link

Change https://golang.org/cl/207402 mentions this issue: misc/chrome/gophertool: replace a deprecated API

@andybons andybons added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Nov 18, 2019
@andybons andybons added this to the Unplanned milestone Nov 18, 2019
@golang golang locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@andybons @gopherbot @ramenjuniti