-
Notifications
You must be signed in to change notification settings - Fork 18k
x/build/cmd/coordinator: tar file entry [...] contained unsupported file type Lrwxrwxrwx #35610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Logs are full of them for all subrepos:
Hm, but symlink support was added in https://go-review.googlesource.com/c/157439 So maybe it's just old buildlets. Rebuilding the openbsd one. (This has probably been a problem for ages but we never had visibility into it before the new scheduler sent buildlet creation logs to stderr, which it's now spamming, for better or worse...) |
Change https://golang.org/cl/207417 mentions this issue: |
Change https://golang.org/cl/207419 mentions this issue: |
For debugging the openbsd-386 buildlet. Turns out it's ancient for some reason. Updates golang/go#35610 Change-Id: Ie003c1b89d0c2d110bc8c70765996c7b71958779 Reviewed-on: https://go-review.googlesource.com/c/build/+/207419 Reviewed-by: Bryan C. Mills <bcmills@google.com>
Noticed while debugging golang/go#35610 that we could get a lot of these lines with no context: 2019-11-15T05:14:15Z fetching_subrepo tools 2019-11-15T05:14:15Z get_source 2019-11-15T05:14:15Z get_source_from_gitmirror 2019-11-15T05:14:15Z finish_get_source_from_gitmirror after 478.3ms 2019-11-15T05:14:15Z finish_get_source after 561ms 2019-11-15T05:14:17Z get_source 2019-11-15T05:14:17Z finish_get_source after 0s 2019-11-15T05:14:18Z get_source 2019-11-15T05:14:18Z get_source_from_gitmirror 2019-11-15T05:14:18Z finish_get_source_from_gitmirror after 9.3ms 2019-11-15T05:14:18Z finish_get_source after 88.7ms 2019-11-15T05:14:19Z get_source 2019-11-15T05:14:19Z get_source_from_gitmirror 2019-11-15T05:14:19Z finish_get_source_from_gitmirror after 9.1ms 2019-11-15T05:14:19Z finish_get_source after 186.8ms 2019-11-15T05:14:19Z get_source 2019-11-15T05:14:19Z finish_get_source after 0s 2019-11-15T05:14:21Z get_source 2019-11-15T05:14:21Z finish_get_source after 0s Change-Id: I5d722f6795964df89878f4c8a7248bc4ad8591e3 Reviewed-on: https://go-review.googlesource.com/c/build/+/207417 Reviewed-by: Bryan C. Mills <bcmills@google.com>
@rorth, the Solaris builder is running buildlet version 15, which is 10 versions behind all the other builders. The builder should ideally be set up to run the x/build/cmd/buildlet/stage0 binary instead, and have that conditionally download the latest buildlet for each build. We build & upload the Solaris binary builds to Google Cloud Storage regularly, but apparently those binaries aren't being used. As a result, some of the Solaris builds are failing on the x/* repos. |
Change https://golang.org/cl/207420 mentions this issue: |
Updates golang/go#35610 Change-Id: I736a439df10b455125688b6c26852c366f9283fe Reviewed-on: https://go-review.googlesource.com/c/build/+/207420 Reviewed-by: Bryan C. Mills <bcmills@google.com>
Brad Fitzpatrick <notifications@github.com> writes:
@rorth, the Solaris builder is running buildlet version 15, which is 10
versions behind all the other builders.
The builder should ideally be set up to run the x/build/cmd/buildlet/stage0
binary instead, and have that conditionally download the latest buildlet
for each build. We build & upload the Solaris binary builds to Google Cloud
Storage regularly, but apparently those binaries aren't being used.
As a result, some of the Solaris builds are failing on the x/* repos.
As I'd mentioned, I've inherited the Solaris builder only a short time
ago. So far, I've mostly kept it running as is, only fixing serious
issues that completely break the build.
I'd seen the "unsupported file type Lrwxrwxrwx" message in the
buildlet's log and started investigating, but hadn't yet gotten to the
root of things.
This weekend, I've replaced the old v15 buildlet binary by a current
one, making those errors go away and allowing the golang.org/x/* builds
to finish successfully. Btw., what's the reason that some of the
golang.org/x/* subrepos are missing from the Dashboard?
Earlier today, I've in turn changed the builder to use stage0 instead of
a local buildlet binary. It connected to the coordinator just fine,
still waiting for a build to start, though.
|
Some of the golang.org/x repos are new-ish and it hasn't been done yet. Some weren't possible to test in the past due to external dependencies and they weren't included, but that has been resolved with the switch to module mode. It's a TODO to add them, e.g., see #30640. |
OpenBSD and Solaris look healthy now. Closing. |
I don't know what to make of this build failure:
It seems like it's build x/tools, but the error message about:
... only comes from the x/build repo.
And that revision is https://go-review.googlesource.com/c/go/+/204641 which was a "go" repo from "release-branch.go1.12". That was from two weeks ago.
So how is the "build" repo involved? And why tools?
/cc @dmitshur @stamblerre @bcmills
The text was updated successfully, but these errors were encountered: