New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: implementation sometimes returns duplicate implementers #35607
Comments
Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here. |
@muirdm I would be willing to work on this as my first issue, if one else is working on it. |
@irajdeep: Thanks, that'd be great! Please feel free to reach out to me here or on Gophers Slack if you need any guidance. |
Hey folks!
Edit: Ignore my above comment. I just realised in vscode the actual command to find the implementations of an interface is The output shows:
So I reckon it works as expected and I can't reporduce the bug in the lastest version of gopls |
Thanks for looking at this. It still happens for me on master. Below is the request/response log showing the duplicate results. Maybe VSCode is de-duping the results? Otherwise, not sure what is going on.
|
Thanks for investigating, @irajdeep. It's definitely possible that VS Code is de-duping. I actually expect that @ridersofrohan's work on fixing #35600 will also resolve this issue. |
So, I checked the logs of
I get 2 responses as expected. I suspect some change since v0.2.0 in master might have introduced it?
Cool, I will hold off working on this issue until then. |
Duplicate of #35600. This seems to be resolved with the fix in that issue. |
For example, when I find implementations of the "matcher" interface in tools/internal/lsp/source/completion.go, I get back:
Note the "insensitivePrefixMatcher" and "prefixMatcher" duplicates.
The text was updated successfully, but these errors were encountered: