New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: go get https://* should work #35598
Comments
|
I definitely wouldn't allow imports like Only suggesting changes to the Ignoring https:// would be cheap to do, and it's a nice experience because it's common practice for a developer to look up a github repository, then copy and paste its url to install it. Currently this fails hard and I think that's a bit unfortunate because the package path can still be determined. |
Sorry, but I disagree. Take https://github.com/mvdan/sh for example; the module's import path is |
Ok nvm then. I thought stripping out https:// would work in most cases and if the import path is not the same as the github repo url (no big deal), |
This has been proposed and declined a few times in the past. Most recently: https://go-review.googlesource.com/c/go/+/205019 But at least once or twice before that as well. I can't find the proposal with GitHub's search now, though. If somebody wants to find it, please link it. But I think we should probably close this. |
Duplicate of #12701 |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
go get https://github.com/rs/zerolog
What did you expect to see?
go get https://github.com/rs/zerolog
go: finding github.com/rs/zerolog v1.16.0
go: downloading github.com/rs/zerolog v1.16.0
go: extracting github.com/rs/zerolog v1.16.0
What did you see instead?
go get https://github.com/rs/zerolog
go get https:/github.com/rs/zerolog: malformed module path "https:/github.com/rs/zerolog": invalid char ':'
Would be nice to see the http protocol allowed because often I am following a guide, or blog post and just copy/paste the repo url in the terminal. I think it's annoying to remove the protocol every time.
The text was updated successfully, but these errors were encountered: