Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript/mod_load_badchain flake on windows-amd64-longtest #35539

Closed
bcmills opened this issue Nov 12, 2019 · 2 comments
Closed

cmd/go: TestScript/mod_load_badchain flake on windows-amd64-longtest #35539

bcmills opened this issue Nov 12, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 12, 2019

2019-11-12T05:35:33-99957b6/windows-amd64-longtest

In CL 204777 I made the "finding versions" log message nondeterministic based on the actual delay of the operation. Perhaps it should be made deterministic — or at least made deterministic during testing — so that output during tests doesn't depend on the load factor of the test machine.

CC @jayconrod

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_load_badchain (15.88s)
        script_test.go:192: 
            # Download everything to avoid "finding" messages in stderr later. (7.343s)
        […]
            > cmp stderr list-missing-test-expected
            [diff -stderr +list-missing-test-expected]
            -go: finding versions for example.com
             go: found example.com/badchain/c in example.com/badchain/c v1.1.0
             go: m/testuse tested by
             	m/testuse.test imports
             	example.com/badchain/c: example.com/badchain/c@v1.1.0: parsing go.mod:
             	module declares its path as: badchain.example.com/c
             	        but was required as: example.com/badchain/c
            
            FAIL: testdata\script\mod_load_badchain.txt:35: stderr and list-missing-test-expected differ
            
FAIL
FAIL	cmd/go	376.850s
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 12, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 12, 2019
@bcmills bcmills self-assigned this Nov 12, 2019
@gopherbot
Copy link

Change https://golang.org/cl/213679 mentions this issue: cmd/go: make "finding" logging deterministic

@bcmills
Copy link
Contributor Author

bcmills commented Jan 7, 2020

We should make the logging deterministic before we cut the RC.

The nondeterministic logging is too confusing (see also #36258).

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 7, 2020
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 7, 2020
@golang golang locked and limited conversation to collaborators Jan 8, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@bcmills @gopherbot