time: TestAfterStop flaky on solaris-amd64-oraclerel #35537
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
OS-Solaris
Milestone
Comments
bcmills
added
the
NeedsInvestigation
|
Interesting that it failed twice in the same way, once with the old timer implementation and once with the new. The test starts a timer to run for 50 milliseconds and assumes that it will stop the timer before that time is up. I wonder if occasionally on Solaris the test program is suspended for long enough for the timer to fire? |
|
Change https://golang.org/cl/207457 mentions this issue: |
|
Ian Lance Taylor <notifications@github.com> writes:
Interesting that it failed twice in the same way, once with the old timer
implementation and once with the new. The test starts a timer to run for
50 milliseconds and assumes that it will stop the timer before that time is
up. I wonder if occasionally on Solaris the test program is suspended for
long enough for the timer to fire?
I've run some experiments myself, both on bare metal and in kernel zones
and on (fully) loaded and idle systems, running
go test -count=1 time
1000 times in a row. I've only managed to provoke the failure in kernel
zones on that particular Opteron system, not e.g. on another kernel zone
running the identical Solaris version on a (faster) Intel CPU.
Strangely, the failures didn't happen when I added -run TestAfterStop.
With your patch, those failures are gone as expected. However, a
related one remains, occurring about 5 out of 1000 times:
…--- FAIL: TestTicker (1.20s)
tick_test.go:26: 10 100ms ticks took 1.200364758s, expected [800ms,1.2s]
|
|
Change https://golang.org/cl/207403 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Nov 19, 2019
Take the opportunity of deflaking to make it take less time to run. Updates #35537 Change-Id: I91ca8094fbe18fbfcd34dfda98da1592c9c82943 Reviewed-on: https://go-review.googlesource.com/c/go/+/207403 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2019-11-12T05:35:33-99957b6/solaris-amd64-oraclerel
2019-10-11T18:07:53-24f9238/solaris-amd64-oraclerel
CC @ianlancetaylor @rorth
The text was updated successfully, but these errors were encountered: