Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember to include CLI Go source files in go mod vendor cache #35502

Closed
mcandre opened this issue Nov 11, 2019 · 2 comments
Closed

Remember to include CLI Go source files in go mod vendor cache #35502

mcandre opened this issue Nov 11, 2019 · 2 comments
Labels
FrozenDueToAge

Comments

@mcandre
Copy link

mcandre commented Nov 11, 2019

Please don't strip cmd paths from go mod vendor caches. Altering the source cache makes it that much harder to track tool dependencies and debug Go systems generally.
@bcmills
Copy link
Contributor

bcmills commented Nov 11, 2019

Per https://golang.org/cmd/go/#hdr-Make_vendored_copy_of_dependencies:

Vendor resets the main module's vendor directory to include all packages needed to build and test all the main module's packages.

CLI main packages are not importable, and thus are not “needed to build and test all the main module's packages” (in the sense of go build or go test). Therefore, they are omitted by design.

@bcmills
Copy link
Contributor

bcmills commented Nov 11, 2019

Duplicate of #29516

@bcmills bcmills marked this as a duplicate of #29516 Nov 11, 2019
@bcmills bcmills closed this as completed Nov 11, 2019
@golang golang locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcandre @bcmills @gopherbot