Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: expose names for CurveID and SignatureScheme #35499

Closed
izolight opened this issue Nov 11, 2019 · 8 comments
Closed

crypto/tls: expose names for CurveID and SignatureScheme #35499

izolight opened this issue Nov 11, 2019 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Proposals (old)
Milestone
Backlog

Comments

@izolight
Copy link
Contributor

The constants for CurveID and SignatureScheme don't have any String() methods.
This makes printing these values (for example in log files) awkward as there is just a number.
To workaround this one can make a map to lookup from the constants to some friendly name (the constant name). As the constants already have custom types it would be best to implement the stringer interface for them in the standard library.
The idea is similiar to #30325
I created a first draft in #35297
@izolight izolight changed the title crypto/tls expose names for CurveID and SignatureScheme proposal: crypto/tls expose names for CurveID and SignatureScheme Nov 11, 2019
@gopherbot gopherbot added this to the Proposal milestone Nov 11, 2019
@katiehockman katiehockman added the Proposal-Crypto Proposal related to crypto packages or other security issues label Nov 11, 2019
@katiehockman
Copy link
Contributor

/cc @FiloSottile

@gopherbot
Copy link

Change https://golang.org/cl/208226 mentions this issue: crypto/tls: add {SignatureScheme,CurveID,ClientAuthType}.String()

@rsc rsc added this to Active in Proposals (old) Feb 12, 2020
@rsc
Copy link
Contributor

rsc commented Feb 12, 2020

Adding to proposal minutes, seems headed for likely accept.

@rsc rsc mentioned this issue Feb 12, 2020
Open
@rsc
Copy link
Contributor

rsc commented Feb 26, 2020

@katiehockman, @FiloSottile, are you in favor of this proposal?

@katiehockman
Copy link
Contributor

@rsc I see no issues with doing this, and the rationale seems reasonable. The CL for this was pretty straight-forward too.

@FiloSottile
Copy link
Contributor

Same, this looks good to me.

@rsc
Copy link
Contributor

rsc commented Mar 4, 2020

Based on the discussion above, this seems like a likely accept.

@rsc rsc moved this from Active to Likely Accept in Proposals (old) Mar 4, 2020
@rsc rsc moved this from Likely Accept to Active in Proposals (old) Mar 4, 2020
@rsc rsc moved this from Active to Likely Accept in Proposals (old) Mar 4, 2020
@rsc
Copy link
Contributor

rsc commented Mar 11, 2020

No change in consensus, so accepting.

@rsc rsc moved this from Likely Accept to Accepted in Proposals (old) Mar 11, 2020
@FiloSottile FiloSottile changed the title proposal: crypto/tls expose names for CurveID and SignatureScheme crypto/tls expose names for CurveID and SignatureScheme Mar 11, 2020
@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. Proposal-Accepted and removed Proposal Proposal-FinalCommentPeriod labels Mar 11, 2020
@rsc rsc modified the milestones: Proposal, Backlog Mar 18, 2020
@FiloSottile FiloSottile changed the title crypto/tls expose names for CurveID and SignatureScheme crypto/tls: expose names for CurveID and SignatureScheme Apr 6, 2020
@ianlancetaylor ianlancetaylor mentioned this issue Jun 12, 2020
Closed
@golang golang locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
No open projects
Proposals (old)
Accepted
Milestone
Backlog
Development

No branches or pull requests
5 participants
@rsc @FiloSottile @izolight @gopherbot @katiehockman