Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/unitchecker: erroras is missing from unitchecker go vet example #35486

Closed
leighmcculloch opened this issue Nov 10, 2019 · 1 comment
Closed

x/tools/go/analysis/unitchecker: erroras is missing from unitchecker go vet example #35486

leighmcculloch opened this issue Nov 10, 2019 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@leighmcculloch
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.13.4 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/leighmcculloch/local/bin"
GOCACHE="/home/leighmcculloch/.cache/go-build"
GOENV="/home/leighmcculloch/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/leighmcculloch/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/leighmcculloch/local/bin/go/1.13.4"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/leighmcculloch/local/bin/go/1.13.4/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/leighmcculloch/devel/golang--tools/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build347884369=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I was looking at the example unitchecker that according to its comments is an example for how to imitate the checks performed by go vet in a unitchecker.

https://github.com/golang/tools/blob/7c3fd4a/go/analysis/unitchecker/main.go

What did you expect to see?

I expected to see all the same analysis checks in the example as what are in the go vet tool.

What did you see instead?

The erroras analysis is missing from the example. It was added to go vet in 9f76566 but it wasn't added to this example at the same time.
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Nov 10, 2019
@leighmcculloch leighmcculloch mentioned this issue Nov 10, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/206238 mentions this issue: go/analysis/unitchecker: add erroras analysis to align with go vet

@bcmills bcmills added help wanted NeedsFix The path to resolution is known, but the work has not been done. and removed help wanted labels Nov 10, 2019
@golang golang locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

go/analysis/unitchecker: add erroras analysis to align with go vet
4 participants
@leighmcculloch @bcmills @gopherbot @matloob