Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: add magic comment or label to pause Gerritbot on a PR #35464

Closed
bradfitz opened this issue Nov 8, 2019 · 3 comments
Closed

x/build/cmd/gerritbot: add magic comment or label to pause Gerritbot on a PR #35464

bradfitz opened this issue Nov 8, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 8, 2019

When I want to take over a CL in Gerrit, I can forge the author and work in peace.

If I want to take over a CL in Gerrit that originated from Gerritbot, I need to race and get my change +2'ed and submitted before Gerritbot wakes up and overwrites my work.

I'd like to be able to leave a comment or set a label on a GitHub PR to disable Gerritbot for that PR.

/cc @andybons @dmitshur @cagedmantis @bcmills
@bradfitz bradfitz added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Nov 8, 2019
@gopherbot gopherbot added this to the Unreleased milestone Nov 8, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 8, 2019
@bradfitz bradfitz changed the title x/build/cmd/gerritbot: add magic comment or label to pause Gerritbot x/build/cmd/gerritbot: add magic comment or label to pause Gerritbot on a PR Nov 8, 2019
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 8, 2019
@bcmills
Copy link
Contributor

bcmills commented Nov 8, 2019

Could GerritBot just compare the timestamp of the last upload with the timestamp of the last PR update? Seems like it should only sync a PR over to Gerrit if the PR contents are newer than the latest Gerrit PatchSet.

@bradfitz
Copy link
Contributor Author

bradfitz commented Nov 8, 2019

That works too, if that's not too difficult.

@andybons
Copy link
Member

andybons commented Nov 8, 2019

Duplicate of #24887

@andybons andybons marked this as a duplicate of #24887 Nov 8, 2019
@andybons andybons closed this as completed Nov 8, 2019
@dmitshur dmitshur mentioned this issue Nov 9, 2019
Open
@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @andybons @bcmills @gopherbot