Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: panic index in FindScavengeCandidate tests #35431

Closed
mknyszek opened this issue Nov 7, 2019 · 1 comment
Closed

runtime: panic index in FindScavengeCandidate tests #35431

mknyszek opened this issue Nov 7, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.14

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Nov 7, 2019

The builder linux-mips64le-mengzhuo is failing at its latest change with a panic index in scavenge tests for the new page allocator.

https://build.golang.org/log/ad51dd54c3603d92b85a219fbbba9c4d21794f3a

The problem is that it has a larger huge page size than any other system I've tested on thus far (32 MiB) so the fix is to just handle those cases correctly, or to no longer handle those cases at all.

I think it's OK to not handle them at all in the short term because our allocator is not huge-page aware, so the likelihood that 32 aligned MiB is going to be totally free and unscavenged is very low. The exception of course is a very large transient heap spike, so this should absolutely get fixed.

I'm going to push a short-term fix and work on a slightly bigger fix.

@bcmills @aclements @randall77 @cherrymui
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2019
@mknyszek mknyszek added this to the Go1.14 milestone Nov 7, 2019
@mknyszek mknyszek self-assigned this Nov 7, 2019
@gopherbot
Copy link

Change https://golang.org/cl/205937 mentions this issue: runtime: define maximum supported physical page and huge page sizes

@mknyszek mknyszek mentioned this issue Nov 8, 2019
Closed
@mknyszek mknyszek changed the title runtime: panic index in FindScavengeCandidate tests. runtime: panic index in FindScavengeCandidate tests Nov 8, 2019
@mknyszek mknyszek added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Nov 8, 2019
@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot