Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestLinuxSendfile failing on mips64 #35423

Closed
bcmills opened this issue Nov 7, 2019 · 6 comments
Closed

net/http: TestLinuxSendfile failing on mips64 #35423

bcmills opened this issue Nov 7, 2019 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 7, 2019 •
edited

linux-mips64-rtrk (https://build.golang.org/log/08c75d4dfe5a50784afe5f032e5510cdc2e4ec8f):

--- FAIL: TestLinuxSendfile (0.37s)
    fs_test.go:1165: no sendfile system call found in:
        [pid 11110] +++ exited with 0 +++
        [pid 11106] +++ exited with 0 +++
        [pid 11109] +++ exited with 0 +++
        [pid 11108] +++ exited with 0 +++
        [pid 11107] +++ exited with 0 +++
        +++ exited with 0 +++
FAIL
FAIL	net/http	19.315s

See previously #18008.

CC @bradfitz @cherrymui @bogojevic @milanknezevic
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 7, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 7, 2019
@cherrymui
Copy link
Member

Does the builder has 64-bit user space? As seen in #18008, the strace command that is not using 64-bit ABI may not work.

@milanknezevic
Copy link
Contributor

@cherrymui The builder has 32-bit user space.

@milanknezevic
Copy link
Contributor

@cherrymui @bradfitz The solution could be to modify the test to check if "n64:sendfile" syscall is used on mips64. Is that ok?

@cherrymui
Copy link
Member

I think I tried that in #18008 (comment)

That was a few years ago. Things may be different now.

@gopherbot
Copy link

Change https://golang.org/cl/206178 mentions this issue: net/http: relax TestLinuxSendfile, trace all system calls, match n64:sendfile

@cherrymui
Copy link
Member

Ok, apparently now we no longer match the arguments, so this may work.

@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @cherrymui @milanknezevic