New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: TestSyscallNoError failing on linux-mipsle-rtrk #35422
Comments
cc @tklauser |
Do I understand correctly that |
Correct. |
On MIPS, the kernel returns whether the syscall has error in a separate register, R7 (https://go.googlesource.com/go/+/refs/heads/master/src/syscall/asm_linux_mipsx.s#107), instead of a negative result. I'm not sure I understand why TestSyscallNoError expects syscall.RawSyscall returns an error while the syscall is not erred. It looks to me that the intent of TestSyscallNoError is that RawSyscallNoError does the right thing, not RawSyscall (incorrectly) returns an error. |
It's not just the error value that's an unexpected value. The first value is also unexpected. It's easier if it's reformatted like this:
|
The first value, 4294967295, is just -1, as set by e.g. https://go.googlesource.com/go/+/refs/heads/master/src/syscall/asm_linux_386.s#79 when RawSyscall thinks it gets an error. Assuming there is no error, 4294967294 is the expected result. |
Change https://golang.org/cl/205898 mentions this issue: |
linux-mipsle-rtrk
(https://build.golang.org/log/7c41de40632a6e8445e6c90e94cb825c3aabdbd8):See previously #30258 (CC @ianlancetaylor @bradfitz)
The text was updated successfully, but these errors were encountered: