Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: import name not added in certain cases #35401

Closed
heschi opened this issue Nov 6, 2019 · 1 comment
Closed

x/tools/gopls: import name not added in certain cases #35401

heschi opened this issue Nov 6, 2019 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Nov 6, 2019

Followup for #35397 and https://golang.org/cl/205657. We should really call importPathToAssumedName somehow here and set up a Name the same way as goimports would.

cc @muirdm
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 6, 2019
@gopherbot
Copy link

Change https://golang.org/cl/206890 mentions this issue: internal/lsp/source: give more imports names

@golang golang locked and limited conversation to collaborators Nov 24, 2020
@rsc rsc unassigned heschi Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @heschi