Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/test: TestCommandLine/.*/Format failing on multiple builders #35392

Closed
bcmills opened this issue Nov 6, 2019 · 1 comment
Closed
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 6, 2019

x/tools/gopls/test is failing on several builders, apparently due to platform differences in diff behavior.

Selected examples:
darwin-amd64-10_14: https://build.golang.org/log/b78bd160bb44734fabf8ab3cab45328df9c5aeee
linux-amd64-fedora: https://build.golang.org/log/5912098920fe26c6bf75d6b3b5a813bbbb2c8e46
linux-s390x-ibm: https://build.golang.org/log/9ae01b35a7f552683daf8c6e301f325c81a57095
netbsd-amd64-8_0: https://build.golang.org/log/f9fedbf3ebfbe897dea6dcf14704ad1cd1a5e45e
illumos-amd64: https://build.golang.org/log/1533fb12f20b1e5d6de5b6046d2f979e15fb9896

Since these failures may mask other regressions in the dashboard, a fix should be prioritized.

CC @stamblerre @ianthehat

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 6, 2019
@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Nov 6, 2019
@gopherbot
Copy link

Change https://golang.org/cl/205739 mentions this issue: gopls: control features for command line tests

@golang golang locked and limited conversation to collaborators Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants