Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "call not at safe point" in TestDebugCall and TestDebugCallStack #35376

Closed
bcmills opened this issue Nov 5, 2019 · 5 comments
Closed

runtime: "call not at safe point" in TestDebugCall and TestDebugCallStack #35376

bcmills opened this issue Nov 5, 2019 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 5, 2019

From the linux-amd64-noopt builder (https://build.golang.org/log/593395f76446a5f9a0f49547be1ee74f3c9eb40d, and many more like it):

--- FAIL: TestDebugCallGrowStack (0.00s)
    debug_test.go:183: call not at safe point
FAIL
FAIL	runtime	20.235s

CC @aclements @mknyszek @danscales
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages) labels Nov 5, 2019
@bcmills bcmills added this to the Go1.14 milestone Nov 5, 2019
@bcmills
Copy link
Contributor Author

bcmills commented Nov 6, 2019

Most of the other regressions on the dashboard seem to be cleared at this point, but this one is still present.
linux-amd64-noopt: https://build.golang.org/log/20ee0977fa1fb3ac44a45711db66f6b4b1aadb2d

@danscales
Copy link
Contributor

As far as I can tell, this only shows up on linux-amd64-noopt , i.e. only for non-optimized code.

@ianlancetaylor
Copy link
Contributor

Running

go test -gcflags="-N -l" -test.run=TestDebugCallGrowStack -test.count=100 runtime

produced 12 test failures on my laptop.

@ianlancetaylor
Copy link
Contributor

The other TestDebugCall tests also fail intermittently.

@gopherbot
Copy link

Change https://golang.org/cl/205718 mentions this issue: runtime: if InjectDebugCall sees "not at safe point", keep trying

@bcmills bcmills changed the title runtime: "call not at safe point" in TestDebugCallStack runtime: "call not at safe point" in TestDebugCall and TestDebugCallStack Nov 8, 2019
@bcmills bcmills mentioned this issue Nov 8, 2019
Closed
@bcmills bcmills mentioned this issue Jan 22, 2020
Closed
@golang golang locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
4 participants
@danscales @ianlancetaylor @bcmills @gopherbot