Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: show periodic buildlet acquisition status updates to stderr #35354

Closed
bradfitz opened this issue Nov 4, 2019 · 2 comments
Closed

x/build/cmd/gomote: show periodic buildlet acquisition status updates to stderr #35354

bradfitz opened this issue Nov 4, 2019 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 4, 2019

People think gomote create hangs when really it's just waiting a long time to get a buildlet (for the statically-provisioned buildlets).

Now that the scheduler is about to land (#19178), it shouldn't be too hard to plumb through position-in-line & queue depth updates down to the gomote binary so it can print out regular status messages.
@gopherbot gopherbot added this to the Unreleased milestone Nov 4, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 4, 2019
@bradfitz bradfitz added FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. and removed Builders x/build issues (builders, bots, dashboards) labels Nov 4, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/207841 mentions this issue: cmd/coordinator, cmd/gomote: show periodic status updates to stderr

gopherbot pushed a commit to golang/build that referenced this issue Nov 20, 2019
@bradfitz
cmd/coordinator, cmd/gomote: show periodic status updates to stderr
6191a53 
Also modernizes some code in the coordinator.

Updates golang/go#35354 (or fixes. But we could return more info.)

Change-Id: Ifc1aa85ca217a0932e388ec5d36ef0737b90c63d
Reviewed-on: https://go-review.googlesource.com/c/build/+/207841
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@dmitshur
Copy link
Contributor

There are definitely regular updates being printed now which provide pretty good information, so I think this issue is less actionable now. We can consider this to be resolved by CL 207841.

@dmitshur dmitshur added this to Done in Go Release Team May 12, 2022
@golang golang locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot