Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash/maphash: finalize API design #35348

Closed
rsc opened this issue Nov 4, 2019 · 1 comment
Closed

hash/maphash: finalize API design #35348

rsc opened this issue Nov 4, 2019 · 1 comment
Labels
FrozenDueToAge release-blocker
Milestone
Go1.14

Comments

@rsc
Copy link
Contributor

rsc commented Nov 4, 2019

hash/maphash's API has one TODO in a public doc comment (MakeSeed) and also various non-idiomatic duplication, like both AddBytes and Write methods that do the same thing.

I sent CL 205069 to fix up the API before we issue it in the Go 1.14 release.

Getting the API finalized obviously blocks its inclusion in the release.
@rsc rsc added this to the Go1.14 milestone Nov 4, 2019
@rsc rsc self-assigned this Nov 4, 2019
@gopherbot
Copy link

Change https://golang.org/cl/205069 mentions this issue: hash/maphash: revise API to be more idiomatic

@golang golang locked and limited conversation to collaborators Nov 3, 2020
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@rsc @gopherbot