Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestFutexsleep failing on freebsd and linux #35347

Closed
bradfitz opened this issue Nov 4, 2019 · 3 comments
Closed

runtime: TestFutexsleep failing on freebsd and linux #35347

bradfitz opened this issue Nov 4, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD OS-Linux release-blocker
Milestone
Go1.14

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 4, 2019

FreeBSD failure I've seen a few times now...

https://storage.googleapis.com/go-build-log/deaf5ba3/freebsd-amd64-12_0_6ba9394d.log

##### GOMAXPROCS=2 runtime -cpu=1,2,4 -quick
--- FAIL: TestFutexsleep (0.02s)
    futex_test.go:65: futexsleep test "before the year 2038" finished early after 20.627855ms
FAIL
FAIL	runtime	14.092s
FAIL
2019/11/04 18:30:12 Failed: exit status 1
2019/11/04 18:30:12 FAILED

/cc @ianlancetaylor
@bradfitz bradfitz added OS-FreeBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 4, 2019
@bradfitz bradfitz added this to the Go1.14 milestone Nov 4, 2019
@mdempsky
Copy link
Member

mdempsky commented Nov 4, 2019

Got the same flake on the linux-amd64 trybot just now: https://storage.googleapis.com/go-build-log/dec1040d/linux-amd64_babdf1c2.log

@mdempsky mdempsky changed the title runtime: TestFutexsleep failing on freebsd runtime: TestFutexsleep failing on freebsd and linux Nov 4, 2019
@ianlancetaylor
Copy link
Contributor

My first guess is that the test is failing because the futex sleep is being interrupted by a preemption signal. The test works by making a direct call to futexsleep, which on GNU/Linux calls futex and on FreeBSD calls sys_umtx_op. The intent is to sleep for a long time. However, these sleeps are interruptible; if a preemption interrupt is delivered, the sleep will wake up and return without error.

CC @aclements @cherrymui

@gopherbot
Copy link

Change https://golang.org/cl/205378 mentions this issue: runtime: disable preemption during test calls to futexsleep

@danscales danscales assigned danscales and unassigned danscales Nov 12, 2019
@golang golang locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-FreeBSD OS-Linux release-blocker
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
5 participants
@bradfitz @mdempsky @danscales @ianlancetaylor @gopherbot