Skip to content

cmd/go: "fatal error: concurrent map writes" during go get [1.13 backport] #35318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Nov 3, 2019 · 4 comments
Closed

cmd/go: "fatal error: concurrent map writes" during go get [1.13 backport] #35318

gopherbot opened this issue Nov 3, 2019 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.13.5

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #35317 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: this is a regression and a data race.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 3, 2019
@gopherbot gopherbot mentioned this issue Nov 3, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.5 milestone Nov 3, 2019
@bcmills bcmills self-assigned this Nov 4, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/205517 mentions this issue: [release-branch.go1.13] cmd/go/internal/modget: synchronize writes to modOnly map in runGet

@dmitshur
Copy link
Contributor

Approving because this is a serious problem without an obvious workaround, and the fix is localized.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Nov 26, 2019
@gopherbot
Copy link
Contributor Author

Closed by merging 674a524 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Nov 26, 2019
[release-branch.go1.13] cmd/go/internal/modget: synchronize writes to…

Verified

This commit was signed with the committer’s verified signature.
talregev
GPG key ID: A421558E0F87AC82
Verified
Learn about vigilant mode
674a524 
… modOnly map in runGet

Updates #35317
Fixes #35318

Change-Id: Id858a25dc16a1bbff1802d25bcd4aca31c1133bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/205067
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 7e71c9c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205517
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/209222 mentions this issue: [release-branch.go1.13] cmd/go/internal/modget: synchronize writes to modOnly map in runGet

gopherbot pushed a commit that referenced this issue Dec 3, 2019
@cagedmantis @toothrot
[release-branch.go1.13] cmd/go/internal/modget: synchronize writes to…

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
GPG key ID: B5ABD165E2AEF201
Verified
Learn about vigilant mode
4f81a32 
… modOnly map in runGet

Adds an additional lock around an access to modOnly.

Updates #35317
Fixes #35318

Change-Id: Ia1e75f9a674ec2a2c0489b41283c1cd3e7924d1e
Reviewed-on: https://go-review.googlesource.com/c/go/+/209237
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 9174e2c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/209222
Run-TryBot: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Dec 2, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.13.5
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot