Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings: TestBuilderAllocs flake on freebsd-386-12_0 #35280

Closed
bcmills opened this issue Oct 31, 2019 · 2 comments
Closed

strings: TestBuilderAllocs flake on freebsd-386-12_0 #35280

bcmills opened this issue Oct 31, 2019 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 31, 2019

freebsd-386-12_0 (https://build.golang.org/log/380c04df9641b3e5274073af6c25f56e5607e60d):

--- FAIL: TestBuilderAllocs (0.00s)
    builder_test.go:193: got 1 alloc(s); want 0
FAIL
FAIL	strings	1.570s

It's not obvious to me whether this is a bug in the test proper or in testing.AllocsPerRun.

CC @bradfitz; see previously #24647.
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 31, 2019
@bcmills bcmills added this to the Backlog milestone Oct 31, 2019
@bradfitz
Copy link
Contributor

I see nothing obviously wrong with the test.

Maybe there's a closure allocation that it's counting?

In any case, perhaps we can just delete it. The test at the bottom of the function (which we're not getting to due to the t.Fatal) seems comprehensive at least and more self-contained (no closure either).

@gopherbot
Copy link

Change https://golang.org/cl/204598 mentions this issue: strings: remove a redundant and flaky part of a test

@golang golang locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bradfitz @bcmills @gopherbot