Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: formatting of build name/type needs some work #35240

Closed
bradfitz opened this issue Oct 30, 2019 · 1 comment
Closed

x/build/cmd/coordinator: formatting of build name/type needs some work #35240

bradfitz opened this issue Oct 30, 2019 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

(follow up from https://go-review.googlesource.com/c/build/+/203677 and https://go-review.googlesource.com/c/build/+/203917)

I just saw some TryBots fail on https://go-review.googlesource.com/c/tools/+/203918 with:

Failed on x/tools (freebsd-amd64-12_0): https://storage.googleapis.com/go-build-log/64533374/freebsd-amd64-12_0_daec2955.log
Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/7ad8def9/linux-amd64_976d9afe.log
Failed on x/tools (linux-amd64): https://storage.googleapis.com/go-build-log/64533374/linux-amd64_6b59de76.log
Failed on x/tools (linux-386): https://storage.googleapis.com/go-build-log/64533374/linux-386_973d534f.log
Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/9e6d3ca2/linux-amd64_98e3827f.log
Failed on x/tools (windows-amd64-2016): https://storage.googleapis.com/go-build-log/64533374/windows-amd64-2016_4deaa219.log
Failed on x/tools (openbsd-amd64-64): https://storage.googleapis.com/go-build-log/64533374/openbsd-amd64-64_07b2844b.log
Failed on x/tools (windows-386-2008): https://storage.googleapis.com/go-build-log/64533374/windows-386-2008_156c20d3.log
Failed on x/tools (linux-amd64-race): https://storage.googleapis.com/go-build-log/64533374/linux-amd64-race_146d0331.log
Failed on x/tools (android-amd64-emu): https://storage.googleapis.com/go-build-log/64533374/android-amd64-emu_154abe68.log

Note how the new "x/tools ($BUILDER)" format is used for all but the (Go 1.12.x) and (Go 1.13.x) lines, which makes it look like they're not testing x/tools, but they are.

In fact, for a TryBot run of non-"go" repos, we probably don't need the "x/tools" at all because they'll all have it.
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 30, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 30, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 30, 2019
@gopherbot
Copy link

Change https://golang.org/cl/204198 mentions this issue: cmd/coordinator: improve formatting of builder names

@golang golang locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @stamblerre @gopherbot