Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/doc: TestDotSlashLookup test failing with "no buildable Go source files" on windows-amd64-longtest #35236

Closed
bcmills opened this issue Oct 29, 2019 · 3 comments
Closed

cmd/doc: TestDotSlashLookup test failing with "no buildable Go source files" on windows-amd64-longtest #35236

bcmills opened this issue Oct 29, 2019 · 3 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 29, 2019 •
edited

From the windows-amd64-longtest builder (https://build.golang.org/log/1f75da0b3de79f29e792f74847515be6a752f475):

2019/10/29 18:56:56 no buildable Go source files in C:\workdir\go\src\text
FAIL	cmd/doc	0.237s

CC @robpike @mvdan @zx2c4 @alexbrainman @iwdgo
@bcmills bcmills added help wanted OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 29, 2019
@bcmills bcmills added this to the Go1.14 milestone Oct 29, 2019
@bcmills bcmills mentioned this issue Oct 29, 2019
Closed
@bcmills
Copy link
Contributor Author

bcmills commented Oct 31, 2019

The terseness of the output comes from an impedance mismatch between the error handling in main.go (which invokes log.Fatal liberally, as if invoked as a binary) and the testing strategy in doc_test.go (which invokes do as though it expects that function to return explicit errors instead of terminating the process).

@gopherbot
Copy link

Change https://golang.org/cl/204442 mentions this issue: cmd/doc: avoid calling token.IsExported on non-tokens

@gopherbot
Copy link

Change https://golang.org/cl/223780 mentions this issue: [release-branch.go1.13] cmd/doc: skip failing TestDotSlashLookup on Windows

@dmitshur dmitshur changed the title cmd/doc: test failing with "no buildable Go source files" on windows-amd64-longtest cmd/doc: TestDotSlashLookup test failing with "no buildable Go source files" on windows-amd64-longtest Mar 17, 2020
gopherbot pushed a commit that referenced this issue Mar 31, 2020
@dmitshur
[release-branch.go1.13] cmd/doc: skip failing TestDotSlashLookup on W…
c67f9cc 
…indows

This test was fixed by changing cmd/doc behavior in CL 204442.

Backporting that non-test code change is unlikely to be appropriate
this late in Go 1.13 release cycle. A failing test can cover up other
regressions, so skip this known failing test to fix the builder.

For #35236.
For #36181.

Change-Id: I07e795e75d7e37bc96ab68607d5d5cc9254342f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/223780
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@bcmills @gopherbot