Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: CL 202581 broke tests at tip #35226

Closed
stamblerre opened this issue Oct 29, 2019 · 2 comments
Closed

x/tools/gopls: CL 202581 broke tests at tip #35226

stamblerre opened this issue Oct 29, 2019 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Example logs: https://build.golang.org/log/b25de7d549ecbd0ae1ee4b93722a2584b4efe3ac

#34348 will help us catch these issues in advance in the future.
@gopherbot gopherbot added this to the Unreleased milestone Oct 29, 2019
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Oct 29, 2019
This was referenced Oct 29, 2019
Closed
Closed
Closed
@stamblerre
Copy link
Contributor Author

https://golang.org/cl/204041 fixed the majority of these failures.
The remaining failure has been diagnosed with a test case in go/ast (see https://golang.org/cl/204197).

@stamblerre
Copy link
Contributor Author

This has been fixed as of https://golang.org/cl/204202.

@golang golang locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot