Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp: depends on unreliable repository #35221

Closed
scudette opened this issue Oct 28, 2019 · 10 comments
Closed

x/exp: depends on unreliable repository #35221

scudette opened this issue Oct 28, 2019 · 10 comments

Comments

@scudette
Copy link

Our current CI builds are failing because https://dmitri.shuralyov.com/gpu/mtl is not online enough. Investigating this I can see that x/exp depends on it.

Is it possible to only add reliable dependencies to the core golang library? This causes a lot of lost time due to CI breakage and folk having to investigate this.

What version of Go are you using (go version)?

$ go version 1.12

Does this issue reproduce with the latest release?

It is intermittent - CI builds break with

go: dmitri.shuralyov.com/gpu/mtl@v0.0.0-20190408044501-666a987793e9: unrecognized import path "dmitri.shuralyov.com/gpu/mtl" (https fetch: Get https://dmitri.shuralyov.com/gpu/mtl?go-get=1: dial tcp 172.93.50.41:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.)

What operating system and processor architecture are you using (go env)?

go env Output
$ go env 
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mic/.cache/go-build"
GOENV="/home/mic/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mic/go/"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.13"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.13/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/mic/projects/velociraptor/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build251680876=/tmp/go-build -gno-record-gcc-switches"

What did you do?

What did you expect to see?

CI builds succeeding

What did you see instead?

Flakey breakage

@gopherbot gopherbot added this to the Unreleased milestone Oct 28, 2019
@scudette scudette changed the title x/exp depends of unreliable repository x/exp depends on unreliable repository Oct 28, 2019
@bradfitz
Copy link
Contributor

a) x/exp is experimental.

b) if you're using proxy.golang.org or another module proxy/cache, then it doesn't matter whether something is up or not.

/cc @dmitshur

@scudette
Copy link
Author

Im acutally not using x/exp directly - go mod graph shows that it is used by cloud.google.com/go@v0.45.1

Perhaps they should not be using x/exp.

@scudette
Copy link
Author

Thank @bradfitz - setting GOPROXY: https://proxy.golang.org in our appveyor.yaml environment block fixed the issue.

Thanks again for your help!

@dmitshur
Copy link
Contributor

It's fixed now, this was https://twitter.com/dmitshur/status/1188949522724073472.

I would've made the same suggestion as @bradfitz to use https://proxy.golang.org. Glad it worked well for you.

@dmitshur dmitshur changed the title x/exp depends on unreliable repository x/exp: depends on unreliable repository Feb 11, 2020
@Nhat002
Copy link

Nhat002 commented Sep 10, 2020

@dmitshur Looks like the server https://dmitri.shuralyov.com/gpu/mtl failed again to day. Could you help check?

go: dmitri.shuralyov.com/gpu/mtl@v0.0.0-20190408044501-666a987793e9: unrecognized import path "dmitri.shuralyov.com/gpu/mtl" (https fetch: Get https://dmitri.shuralyov.com/gpu/mtl?go-get=1: dial tcp 172.93.50.41:443: i/o timeout)

Setting GOPROXY: https://proxy.golang.org will block us from using Go private library since go 1.12 does not allow for multiple proxy sources in GOPROXY (using comma).
Only go1.13 allow comma separated list in GOPROXY (#33725)

@Nhat002
Copy link

Nhat002 commented Sep 10, 2020

Does the Go team has any plan or checklist or document on using non reliable source (for both release and experimental packages)? If yes then could you help direct me to it? I need it for our company's incident report since this issue block our CI/CD pipeline. Thanks a lot.

@akfaew
Copy link

akfaew commented Sep 10, 2020

Can anyone advise how to set GOPROXY when deploying to Google AppEngine Standard?

@vvakame
Copy link

vvakame commented Sep 10, 2020

me too. I'm using AppEngine 1st gen still, It uses Go 1.11 ... We wanna move into 2nd gen. But it's not easy for our teams.

@davecheney
Copy link
Contributor

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For asking questions, see:

@Nhat002
Copy link

Nhat002 commented Sep 10, 2020

Thank you @davecheney!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants