Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/term: needs x/sys upgrade for freebsd-arm64 #35182

Closed
bcmills opened this issue Oct 26, 2019 · 2 comments
Closed

x/term: needs x/sys upgrade for freebsd-arm64 #35182

bcmills opened this issue Oct 26, 2019 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 26, 2019

From the freebsd-arm64-dmgk builder (https://build.golang.org/log/da798266d1c726e10eef98c1b2c306066d786f79):

go: finding golang.org/x/sys v0.0.0-20191010194322-b09406accb47
# golang.org/x/sys/unix
../../../../pkg/mod/golang.org/x/sys@v0.0.0-20191010194322-b09406accb47/unix/ztypes_freebsd_arm64.go:400:12: undefined: uint128
FAIL	golang.org/x/term [build failed]

There is no such failure in the builder for the x/sys subrepo, so presumably it just needs an update.

CC @tklauser @dmgk
@bcmills bcmills added Suggested Issues that may be good for new contributors looking for work to do. help wanted OS-FreeBSD NeedsFix The path to resolution is known, but the work has not been done. labels Oct 26, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 26, 2019
@gopherbot
Copy link

Change https://golang.org/cl/203617 mentions this issue: term: fix build on freebsd/arm64

gopherbot pushed a commit to golang/term that referenced this issue Oct 26, 2019
@dmgk @bradfitz
term: fix build on freebsd/arm64
761de04 
Updates golang/go#35182

Change-Id: Ie108dbc04e97d9e120f64686fbf7fe1d51d7de5f
Reviewed-on: https://go-review.googlesource.com/c/term/+/203617
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@tklauser
Copy link
Member

Fixed by https://golang.org/cl/203617

@golang golang locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@tklauser @bcmills @gopherbot