x/tools/gopls: off-by-one in diagnostic results? #35116
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
These might be intentional changes, in which case these issues are just to clarify the changes.
The following file:
results in the following diagnostic:
That's the LSP line reference, which human terms is line 4, position 1. But there is no line 4.
Also the following file:
results in the following diagnostic:
This diagnostic has a start position of the
{
of the function, which I don't think is right? Should this be a zero length diagnostic at the closing}
?What did you expect to see?
Per above
What did you see instead?
Per above
cc @stamblerre
The text was updated successfully, but these errors were encountered: