Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: the wrong sysctl was gimped on iOS [1.13 backport] #35105

Closed
gopherbot opened this issue Oct 23, 2019 · 4 comments
Closed

syscall: the wrong sysctl was gimped on iOS [1.13 backport] #35105

gopherbot opened this issue Oct 23, 2019 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.4

Comments

@gopherbot
Copy link

@zx2c4 requested issue #35101 to be considered for backport to the next 1.13 minor release.

@gopherbot Please backport this to 1.13, because it fixes a grave regression in the net package introduced in 1.13.3.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 23, 2019
@gopherbot gopherbot mentioned this issue Oct 23, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.4 milestone Oct 23, 2019
@zx2c4 zx2c4 mentioned this issue Oct 23, 2019
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/202779 mentions this issue: [release-branch.go1.13] syscall: reenable sysctl on iOS

@zx2c4
Copy link
Contributor

zx2c4 commented Oct 23, 2019

CC @eliasnaur

gopherbot pushed a commit that referenced this issue Oct 25, 2019
@zx2c4 @ianlancetaylor
[release-branch.go1.13] syscall: reenable sysctl on iOS
7ad8def 
This was disabled due to a report that the App Store rejects the symbol
__sysctl. However, we use the sysctl symbol, which is fine. The __sysctl
symbol is used by x/sys/unix, which needs fixing instead. So, this
commit reenables sysctl on iOS, so that things like net.InterfaceByName
can work again.

This reverts CL 193843, CL 193844, CL 193845, and CL 193846.

Fixes #35105
Updates #35101
Updates #34133
Updates #35103

Change-Id: Ib8eb9f87b81db24965b0de29d99eb52887c7c60a
Reviewed-on: https://go-review.googlesource.com/c/go/+/202778
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/202779
Reviewed-by: Elias Naur <mail@eliasnaur.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Author

Closed by merging 7ad8def to release-branch.go1.13.

@dmitshur
Copy link
Contributor

dmitshur commented Nov 1, 2019

This cherry-pick has been approved and included in the Go 1.13.4 release. Updating the label to reflect that.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Nov 1, 2019
@golang golang locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.4
Development

No branches or pull requests
3 participants
@zx2c4 @dmitshur @gopherbot