Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: transport caches permanently broken persistent connections if write error happens during h2 handshake [1.13 backport] #35087

Closed
gopherbot opened this issue Oct 22, 2019 · 3 comments
Closed

net/http: transport caches permanently broken persistent connections if write error happens during h2 handshake [1.13 backport] #35087

gopherbot opened this issue Oct 22, 2019 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.4

Comments

@gopherbot
Copy link

@bradfitz requested issue #34978 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 22, 2019
@gopherbot gopherbot mentioned this issue Oct 22, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.4 milestone Oct 22, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/202642 mentions this issue: [release-branch.go1.13] net/http: don't cache http2.erringRoundTripper connections

gopherbot pushed a commit that referenced this issue Oct 23, 2019
@bradfitz
[release-branch.go1.13] net/http: don't cache http2.erringRoundTrippe…
b2df6bf 
…r connections

Fixes #35087
Updates #34978

Change-Id: I3baf1392ba7366ae6628889c47c343ef702ec438
Reviewed-on: https://go-review.googlesource.com/c/go/+/202078
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 88186e5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/202642
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@gopherbot
Copy link
Author

Closed by merging b2df6bf to release-branch.go1.13.

@bcmills bcmills mentioned this issue Oct 23, 2019
Closed
@BenTheElder BenTheElder mentioned this issue Nov 1, 2019
Merged
@dmitshur
Copy link
Contributor

dmitshur commented Nov 1, 2019

This cherry-pick has been approved and included in the Go 1.13.4 release. Updating the label to reflect that.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Nov 1, 2019
@ncw ncw mentioned this issue Nov 2, 2019
Open
@golang golang locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.4
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot