Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: CORS in fmt/edit routes #35019

Closed
mo4islona opened this issue Oct 20, 2019 · 4 comments
Closed

x/playground: CORS in fmt/edit routes #35019

mo4islona opened this issue Oct 20, 2019 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mo4islona
Copy link

Playground snippets are not working properly on third-party sites.
fmt/edit routes are blocking by CORS.

I am working on new concept of snippets that can be easily integrated in any React app or even standalone. Take a look on https://mo4islona.github.io/material-go-playground/ it has a lot of examples. But some function are not working because of CORS policy.

I have a PR that fixes routes: https://go-review.googlesource.com/c/playground/+/193798
@gopherbot
Copy link

Change https://golang.org/cl/193798 mentions this issue: playground: add CORS headers to fmt/edit route

@dmitshur dmitshur changed the title playground: CORS in fmt/edit routes x/playground: CORS in fmt/edit routes Oct 21, 2019
@gopherbot gopherbot added this to the Unreleased milestone Oct 21, 2019
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 21, 2019
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 3, 2019
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 3, 2019
@mo4islona
Copy link
Author

Fix is here - https://go-review.googlesource.com/c/playground/+/193798
Could it be merged?

@toothrot
Copy link
Contributor

@mo4islona Sorry about the delay on this. I'll work on getting it deployed today, if it hasn't automatically deployed already.

@toothrot
Copy link
Contributor

@mo4islona This is finally deployed. There were several issues blocking deployments to the playground that have since been resolved.

@golang golang locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@toothrot @mo4islona @dmitshur @gopherbot