-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: delete IN_KUBERNETES env #34956
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
bradfitz
added
the
NeedsFix
The path to resolution is known, but the work has not been done.
label
Oct 17, 2019
Change https://golang.org/cl/201737 mentions this issue: |
Change https://golang.org/cl/201739 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Oct 17, 2019
…urther Updates #34956 Change-Id: I35c39f3afda7226eeae0fd6936f7ee0d5d6c025b Reviewed-on: https://go-review.googlesource.com/c/go/+/201737 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
Change https://golang.org/cl/202021 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Oct 19, 2019
…Buster The earlier fix to remove IN_KUBERNETES in buildlet/stage0/stage0.go in CL 201739 caused Kubernetes-based cross compilation builds on fail to start up because I forgot to rebuild & push those container images. But when I went to re-push them, I found they're too old (Debian Jessie) and don't build anymore. So update them to Debian Buster. While I'm here, remove the Debian release name from their image name, as this won't be the last time we need to upgrade them. Unlike real builders, the OS release isn't the point of these containers, as they don't run tests. They exist only to do builds, so the OS isn't interesting or worth calling out. Updates golang/go#34956 Change-Id: Iee4691a821421b161a9333b4441f83ff45d1ffec Reviewed-on: https://go-review.googlesource.com/c/build/+/202021 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codebien
pushed a commit
to codebien/build
that referenced
this issue
Nov 13, 2019
Fixes golang/go#34956 Change-Id: Ie6f521eee5995102d6dc13f92ecca6601a68661b Reviewed-on: https://go-review.googlesource.com/c/build/+/201739 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
codebien
pushed a commit
to codebien/build
that referenced
this issue
Nov 13, 2019
…Buster The earlier fix to remove IN_KUBERNETES in buildlet/stage0/stage0.go in CL 201739 caused Kubernetes-based cross compilation builds on fail to start up because I forgot to rebuild & push those container images. But when I went to re-push them, I found they're too old (Debian Jessie) and don't build anymore. So update them to Debian Buster. While I'm here, remove the Debian release name from their image name, as this won't be the last time we need to upgrade them. Unlike real builders, the OS release isn't the point of these containers, as they don't run tests. They exist only to do builds, so the OS isn't interesting or worth calling out. Updates golang/go#34956 Change-Id: Iee4691a821421b161a9333b4441f83ff45d1ffec Reviewed-on: https://go-review.googlesource.com/c/build/+/202021 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
The IN_KUBERNETES environment variable used to mean something, and its meaning morphed over time, and now it's just an overloaded mess that might not even be used.
Delete it, and then replace it as needed with more specific checks.
/cc @bcmills
The text was updated successfully, but these errors were encountered: