New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: automate daily updates of gopls/go.mod #34952
Comments
Thanks for reporting, I can reproduce it too. It's a build problem on golang/tools@846f856 commit (edit: it happens only when gopls isn't the main module and its replace directive is ignored). /cc @stamblerre For some reason, the builders didn't catch this failure. I'll look into that. If you just want to install the latest released version, you can use |
The problem is that gopls uses |
@fsouza Thanks, that explains why builders didn't catch it. The replace directive was used during tests because |
@dmitshur I know about
Is there an issue about |
Maybe #30515? See comment: #30515 (comment) |
I think the issue is that we just haven't updated the |
I typically pull (Technically, I use a custom tool I wrote to manage binaries with modules which can copy upstream replacements to a local mod file, though admittedly not relative ones at the moment.) |
I ran into this and worked around it by making my own go.mod that pulls up the x/tools version to one that works with gopls.
It feels like the go.mod of golang.org/x/tools/gopls should have a working version at all times (as tested by the builders), or a completely fake one (like v0.0.0, so the build will fail more obviously), if the only allowed way to build is with gopls as the main module. |
Totally agree that getting |
I will be curious about how the new EDIT: Based on the discussion in the |
At this point, we are recommending that users download |
Not sure if there's something wrong with my installation or the repo. Here's what I try to do, and what used to work before:
Shell log
EDIT: A colleague of mine has the same issue.
The text was updated successfully, but these errors were encountered: