Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: go vet -vettool=$(which shadow) errors in go1.13 only (flag provided but not defined: -unsafeptr) [1.13 backport] #34922

Closed
gopherbot opened this issue Oct 15, 2019 · 2 comments
Closed

cmd/vet: go vet -vettool=$(which shadow) errors in go1.13 only (flag provided but not defined: -unsafeptr) [1.13 backport] #34922

gopherbot opened this issue Oct 15, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link

@bcmills requested issue #34053 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: this was an early regression and the fix is trivial.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 15, 2019
@gopherbot gopherbot mentioned this issue Oct 15, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 15, 2019
@gopherbot
Copy link
Author

Change https://golang.org/cl/201237 mentions this issue: [release-branch.go1.13] cmd/go/internal/work: fix error while passing custom vet tool

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Oct 17, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 17, 2019
@gopherbot
Copy link
Author

Closed by merging 0b575b4 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Oct 17, 2019
@agnivade @toothrot
[release-branch.go1.13] cmd/go/internal/work: fix error while passing…
0b575b4 
… custom vet tool

For GOROOT packages, we were adding -unsafeptr=false to prevent unsafe.Pointer
checks. But the flag also got passed to invocations of go vet with a custom
vet tool. To prevent this from happening, we add this flag only when no
tools are passed.

Updates #34053
Fixes #34922

Change-Id: I8bcd637fd8ec423d597fcdab2a0ceedd20786019
Reviewed-on: https://go-review.googlesource.com/c/go/+/200957
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 902d5aa)
Reviewed-on: https://go-review.googlesource.com/c/go/+/201237
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
3 participants
@toothrot @gopherbot @katiehockman