path, path/filepath: document that Clean removes trailing slash #3492
Labels
Milestone
Comments
Both ways are fine with me, but at http://golang.org/pkg/path/#Clean it isn't mentioned and I don't want my program to break just because the compiler was made compliant with the definition. So I just want to know if I have to expect a change in the definition or a change in the implementation of the compiler |
If the documentation is unclear should be updated. The returned path will be as clean as it can be. Labels changed: added priority-soon, documentation, removed priority-triage. Owner changed to @robpike. Status changed to Accepted. |
|
Comment 5 by jo@durchholz.org: The trailing slash should be removed.
That way, the cleaned path will work not just for directories but for files as well.
The main description is clear ("shortest equivalent"), but the detail explanation on
http://golang.org/pkg/path/filepath/#Clean shoud list trailing slash removal as fifth
point.
|
|
This issue was closed by revision 5fc2af1. Status changed to Fixed. |
robpike
added a commit
that referenced
this issue
May 11, 2015
««« backport ab273014412e path: document that Clean deletes trailing slashes. Fixes #3492. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/6112044 »»»
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
by Scheintoter:
What steps will reproduce the problem? My problem is with the functions path.Clean and filepath.Clean. They remove a trailing slash at the end of a path. After reading the documentation I thought it would keep that slash. Could you please fix the bug or if it is intended that way change the documentation? Example: testPath := "/this/is/a/test/" fmt.Printf("original: %s\n", testPath) fmt.Printf("cleaned path: %s\n", path.Clean(testPath)) fmt.Printf("cleaned filepath: %s\n", filepath.Clean(testPath)) full program at: http://play.golang.org/p/l1L6kGlYLE What is the expected output? original: /this/is/a/test/ cleaned path: /this/is/a/test/ cleaned filepath: /this/is/a/test/ (on linux) cleaned filepath: \this\is\a\test\ (on windows) What do you see instead? original: /this/is/a/test/ cleaned path: /this/is/a/test cleaned filepath: /this/is/a/test (on play.golang.org) cleaned filepath: \this\is\a\test (on my windows computer) Which compiler are you using (5g, 6g, 8g, gccgo)? Not sure was is behind the go.exe from the go1 release Which operating system are you using? Windows 7 64 bit Which version are you using? (run 'go version') go version go1The text was updated successfully, but these errors were encountered: