New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/smtp: change expected command for RCPT to 250 #34903
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: f2408dd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/201078 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/201078. |
Message from Brad Fitzpatrick: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/201078. |
Message from Santiago De la Cruz: Patch Set 2:
Commit message updated. About test. The smtp_test.go is correct sending 250 OK after RCPT in all variables and functions, so the test is done and isn't need it an update. Please don’t reply on this GitHub thread. Visit golang.org/cl/201078. |
Closed by conversation about expectCode in #17036 expectCode works in a range, if expectCode is 25 then a valid code is in range 250-259 |
According to RFC5321 https://tools.ietf.org/html/rfc5321 the RCPT command returns 250 when result is OK