Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: broken links to https://blog.golang.org/go-fmt-your-code #34894

Closed
mostynb opened this issue Oct 14, 2019 · 6 comments
Closed

doc: broken links to https://blog.golang.org/go-fmt-your-code #34894

mostynb opened this issue Oct 14, 2019 · 6 comments
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@mostynb
Copy link
Contributor

mostynb commented Oct 14, 2019

I followed a reference from a random go project's git hook to https://golang.org/misc/git/pre-commit and discovered a pseudo 404/"lstat $GOROOT/misc/git/pre-commit: no such file or directory" error. So I looked around some more and found another broken link to this URL from the go blog:
https://blog.golang.org/go-fmt-your-code

It seems that this file was removed back in January:
https://go-review.googlesource.com/c/go/+/158677

I wonder if it's worth making this link work again (either just on the website but not in the git repository, or re-adding the file to the repository with a "DEPRECATED, SEE ..." comment), or maybe editing that blog entry to point to the last commit where that file existed:
https://github.com/golang/go/blob/88da9ccb98ffaf84bb06b98c9a24af5d0a7025d2/misc/git/pre-commit
@mostynb
Copy link
Contributor Author

mostynb commented Oct 14, 2019

@agnivade ^

@agnivade
Copy link
Contributor

We should definitely fix the blog link. Perhaps we can ask users to run a git codereview hooks to install the hooks.

@andybons

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 18, 2019
@marcsanmi
Copy link

marcsanmi commented Oct 27, 2019 •
edited

Can I take a look at this?
Eager to start my 1st contribution to the project :)

@mostynb
Copy link
Contributor Author

mostynb commented Oct 27, 2019

@marcsanmi: I didn't realise the blog was on github until now. You could submit a PR to fix the link:
https://github.com/golang/blog/blob/master/content/go-fmt-your-code.article

@marcsanmi
Copy link

Ok, tomorrow I am going to do it

@mostynb
Copy link
Contributor Author

mostynb commented Dec 1, 2019

Looks like this was fixed:
golang/blog@0a405bc

@mostynb mostynb closed this as completed Dec 1, 2019
@golang golang locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@agnivade @julieqiu @mostynb @marcsanmi @gopherbot