Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/release: windows installer for Go 1.13.1 creates a broken link to godoc.exe #34892

Closed
pilkjaer opened this issue Oct 14, 2019 · 5 comments
Closed

x/build/cmd/release: windows installer for Go 1.13.1 creates a broken link to godoc.exe #34892

pilkjaer opened this issue Oct 14, 2019 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@pilkjaer
Copy link

pilkjaer commented Oct 14, 2019 •
edited

godoc was removed from the installation as for #30029 but Windows installer still creates a link to godoc.exe in the Start menu for that script which is no longer present in the installation and results in file not found error.

What version of Go are you using (go version)?

$ go version
go version go1.13.1 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

What did you do?

What did you expect to see?

What did you see instead?
@julieqiu julieqiu changed the title Installer Go 1.31.1 for windows still creates broken link on godoc.exe Windows installer for Go 1.13.1 creates a broken link to godoc.exe Oct 15, 2019
@julieqiu
Copy link
Member

/cc @alexbrainman @bradfitz

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 15, 2019
@julieqiu julieqiu added this to the Unreleased milestone Oct 15, 2019
@WhitG
Copy link

WhitG commented Oct 15, 2019

I'm having the same issue for Windows Installer for Go 1.13.1 creating the broken link to godoc.exe

@bradfitz bradfitz changed the title Windows installer for Go 1.13.1 creates a broken link to godoc.exe x/build/cmd/releaselet: windows installer for Go 1.13.1 creates a broken link to godoc.exe Oct 15, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 15, 2019
@bradfitz
Copy link
Contributor

x/build/cmd/release/releaselet.go needs to only conditionally include:

    <Shortcut                                                                                                                                                                      
        Id="GoDocServerStartMenuShortcut"                                                                                                                                          
        Name="GoDocServer"                                                                                                                                                         
        Description="Starts the Go documentation server (http://localhost:6060)"                                                                                                   
        Show="minimized"                                                                                                                                                           
        Arguments='/c start "Godoc Server http://localhost:6060" "[INSTALLDIR]bin\godoc.exe" -http=localhost:6060 -goroot="[INSTALLDIR]." &amp;&amp; start http://localhost:6060'  
        Icon="gopher.ico"                                                                                                                                                          
        Target="[%ComSpec]" />

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 15, 2019
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 15, 2019
@bradfitz bradfitz changed the title x/build/cmd/releaselet: windows installer for Go 1.13.1 creates a broken link to godoc.exe x/build/cmd/release: windows installer for Go 1.13.1 creates a broken link to godoc.exe Oct 15, 2019
@bradfitz bradfitz modified the milestones: Unreleased, Go1.14 Oct 15, 2019
@gopherbot
Copy link

Change https://golang.org/cl/201201 mentions this issue: cmd/release: don't include a godoc shortcut in Windows installer

@bradfitz bradfitz self-assigned this Oct 15, 2019
@WhitG
Copy link

WhitG commented Oct 15, 2019

Thanks for the shortcut @bradfitz
Not sure if it will be short for me though :) I'm completely brand new to programming

codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@bradfitz @codebien
cmd/release: don't include a godoc shortcut in Windows installer
3be2d7c 
Fixes golang/go#34892

Change-Id: I9dc14575677c3a4d75a12556896dbed340d442cc
Reviewed-on: https://go-review.googlesource.com/c/build/+/201201
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
5 participants
@bradfitz @pilkjaer @julieqiu @gopherbot @WhitG