Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Client.Do() panics when URL includes HTTP basic auth [1.12 backport] #34881

Closed
gopherbot opened this issue Oct 13, 2019 · 5 comments
Closed

net/http: Client.Do() panics when URL includes HTTP basic auth [1.12 backport] #34881

gopherbot opened this issue Oct 13, 2019 · 5 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.12

Comments

@gopherbot
Copy link

@odeke-em requested issue #34878 to be considered for backport to the next 1.12 minor release.

Thank you for the report @bradleyjkemp!

This a new panic in Go1.13 that stems from the fact that invoking Header.Clone() when Header is nil returns a nil map as we implemented in CL https://go-review.googlesource.com/c/go/+/188022 to solve the inconsistency behavior of Clone as per #33141, but we didn't go through all the call sites to check that the map was nil before assignment.

The code posted up used to work in Go1.12 and before, now fails in Go1.13.
/cc @andybons @bradfitz @FiloSottile for awareness

@gopherbot please backport this issue to Go1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 13, 2019
@gopherbot gopherbot mentioned this issue Oct 13, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.11 milestone Oct 13, 2019
@odeke-em
Copy link
Member

Odd, in #34878 (comment) I had typed @gopherbot please backport this issue to Go1.13. and it opened a backport to Go1.12 so I'll manually close this one.

This was referenced Oct 13, 2019
Closed
Closed
@gopherbot
Copy link
Author

Backport issue(s) opened: #34883 (for 1.12), #34884 (for 1.13).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@av86743
Copy link

av86743 commented Oct 13, 2019

Notice that #34883 is now closed, too.

@bradfitz
Copy link
Contributor

@odeke-em, you might need a space after "Go". File a bug to fix the bot?

@odeke-em odeke-em mentioned this issue Oct 14, 2019
Closed
@odeke-em
Copy link
Member

Notice that #34883 is now closed, too.

@av86743 yes I intentionally closed it as it was opened by the bot seeing itself being summoned.

@odeke-em, you might need a space after "Go". File a bug to fix the bot?

TIL, thank you @bradfitz, I've opened #34887.

@katiehockman katiehockman modified the milestones: Go1.12.11, Go1.12.12 Oct 17, 2019
@dmitshur dmitshur mentioned this issue Mar 4, 2020
Open
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.12
Development

No branches or pull requests
5 participants
@bradfitz @av86743 @odeke-em @gopherbot @katiehockman