Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/reflectlite: TestMirrorWithReflect failing on darwin-arm64-mn4m2zdaios builder #34847

Closed
bcmills opened this issue Oct 11, 2019 · 1 comment
Closed

internal/reflectlite: TestMirrorWithReflect failing on darwin-arm64-mn4m2zdaios builder #34847

bcmills opened this issue Oct 11, 2019 · 1 comment
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.14

Comments

@bcmills
Copy link
Contributor

bcmills commented Oct 11, 2019 •
edited

From the darwin-arm64-mn4m2zdaios builder, a failure in the regression test for #34486 (https://build.golang.org/log/048cb165b4cd25eb76cb1c4c9b6bb2b2b93a47ce):

lldb: running program
panic: open /private/var/folders/qq/qxn86k813bn9fjxydm095rxw0000gp/T/workdir-host-darwin-amd64-zenly-ios/go/src/reflect: no such file or directory

goroutine 49 [running]:
internal/reflectlite_test.loadTypes(0x1300c6310, 0x6b, 0x102be18fe, 0x7, 0x1300c28a0)
	/private/var/folders/qq/qxn86k813bn9fjxydm095rxw0000gp/T/workdir-host-darwin-amd64-zenly-ios/go/src/internal/reflectlite/reflect_mirror_test.go:79 +0x130
internal/reflectlite_test.TestMirrorWithReflect.func1(0x1300cace0, 0x1300c6310, 0x6b, 0x102be18fe, 0x7, 0x1300c28a0)
	/private/var/folders/qq/qxn86k813bn9fjxydm095rxw0000gp/T/workdir-host-darwin-amd64-zenly-ios/go/src/internal/reflectlite/reflect_mirror_test.go:104 +0x70
created by internal/reflectlite_test.TestMirrorWithReflect
	/private/var/folders/qq/qxn86k813bn9fjxydm095rxw0000gp/T/workdir-host-darwin-amd64-zenly-ios/go/src/internal/reflectlite/reflect_mirror_test.go:102 +0x1e0
FAIL	internal/reflectlite	27.257s

The iOS builders copy the test binary and (its testdata directory, if any) over to the builder before running, so tests that require files from elsewhere in GOROOT must be skipped.

Looks like a simple fix, so I'll send a CL.

CC @cuonglm @mvdan
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. mobile Android, iOS, and x/mobile labels Oct 11, 2019
@bcmills bcmills added this to the Go1.14 milestone Oct 11, 2019
@bcmills bcmills self-assigned this Oct 11, 2019
@bcmills bcmills mentioned this issue Oct 11, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/200657 mentions this issue: internal/reflectlite: skip TestMirrorWithReflect reflect package source is unavailable

@golang golang locked and limited conversation to collaborators Oct 10, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@bcmills @gopherbot