Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestSelectFairness flake on linux-386 builder #34808

Closed
cuonglm opened this issue Oct 10, 2019 · 3 comments
Closed

runtime: TestSelectFairness flake on linux-386 builder #34808

cuonglm opened this issue Oct 10, 2019 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.14

Comments

@cuonglm
Copy link
Member

cuonglm commented Oct 10, 2019

Build log https://storage.googleapis.com/go-build-log/83e0a3af/linux-386_d22ef102.log

--- FAIL: TestSelectFairness (0.01s)
    chan_test.go:486: 4770 5230 0.477 0.02300000000000002
    chan_test.go:488: unfair select: in 10000 trials, results were 4770, 5230
FAIL
FAIL	runtime	23.698s
FAIL
2019/10/10 03:35:41 Failed: exit status 1

Got this when testing CL https://go-review.googlesource.com/c/go/+/200237
@ALTree ALTree added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 10, 2019
@bcmills bcmills changed the title testing: FAIL: TestSelectFairness (0.01s) runtime: TestSelectFairness flake on linux-386 builder Oct 10, 2019
@bcmills bcmills added this to the Go1.14 milestone Oct 10, 2019
@bcmills
Copy link
Contributor

bcmills commented Oct 10, 2019

CC @randall77 @aclements

@randall77
Copy link
Contributor

We just crossed the threshold, the error is 0.023 and the reporting threshold is 0.022086.
We could probably turn down this test a bit - it assumes perfect random numbers and fastrand isn't quite that.
@rasky

@gopherbot
Copy link

Change https://golang.org/cl/200857 mentions this issue: runtime: adjust expected error threshold in TestSelectFairness

@golang golang locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
5 participants
@ALTree @cuonglm @bcmills @randall77 @gopherbot